Skip to content

add cypress coverage for manage columns behaviour in hardware conf table#2732

Open
Philip-Carneiro wants to merge 3 commits into
kubeflow:mainfrom
Philip-Carneiro:test/manage-columns-cypress-coverage
Open

add cypress coverage for manage columns behaviour in hardware conf table#2732
Philip-Carneiro wants to merge 3 commits into
kubeflow:mainfrom
Philip-Carneiro:test/manage-columns-cypress-coverage

Conversation

@Philip-Carneiro

@Philip-Carneiro Philip-Carneiro commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

Added cypress coverage to Manage Columns in Hardware Configuration Table

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@google-oss-prow google-oss-prow Bot requested review from chambridge and fege May 20, 2026 14:13
manaswinidas
manaswinidas suggested changes May 29, 2026
View reviewed changes

@manaswinidas manaswinidas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Cypress coverage for manage columns! A few items to clean up around DRY and redundant assertions.

Comment thread clients/ui/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalog/manageColumns.cy.ts Outdated
Comment thread clients/ui/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalog/manageColumns.cy.ts Outdated
Comment thread clients/ui/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalog/manageColumns.cy.ts Outdated
Comment thread clients/ui/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalog/manageColumns.cy.ts Outdated
Comment thread clients/ui/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalog/manageColumns.cy.ts
@manaswinidas

manaswinidas commented May 29, 2026

Copy link
Copy Markdown
Contributor

Informational — library coverage gap

9 of the 16 tests here (toggle, cancel, persist, restore-defaults, search) exercise ManageColumnsModal / useManageColumns behavior from mod-arch-shared. The mod-arch-library repo has test infrastructure (both Cypress and unit) but zero coverage for these components today.

These tests are valuable as the only coverage that currently exists, so not blocking on this — but ideally this coverage should move upstream as unit/component tests in mod-arch-library, leaving only a smoke test + the app-specific latency filter interaction tests here.

@Philip-Carneiro Philip-Carneiro force-pushed the test/manage-columns-cypress-coverage branch from d16a5a3 to 68cccf2 Compare June 2, 2026 09:38
@google-oss-prow

google-oss-prow Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from manaswinidas. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@manaswinidas

manaswinidas commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reiterating my previous comment, 10 of 16 tests exercise generic ManageColumnsModal / useManageColumns behavior and could move upstream to mod-arch-library as unit/component tests. This would leave only a smoke test (open modal, toggle one column) plus the 5 app-specific latency filter interaction tests here. Can we move them ?

@Philip-Carneiro Philip-Carneiro force-pushed the test/manage-columns-cypress-coverage branch 2 times, most recently from df65ac6 to f7fb7d1 Compare June 8, 2026 16:09
@Philip-Carneiro

Philip-Carneiro commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Informational — library coverage gap

9 of the 16 tests here (toggle, cancel, persist, restore-defaults, search) exercise ManageColumnsModal / useManageColumns behavior from mod-arch-shared. The mod-arch-library repo has test infrastructure (both Cypress and unit) but zero coverage for these components today.

These tests are valuable as the only coverage that currently exists, so not blocking on this — but ideally this coverage should move upstream as unit/component tests in mod-arch-library, leaving only a smoke test + the app-specific latency filter interaction tests here.

I moved the tests to the place you suggested o/

@Philip-Carneiro

Philip-Carneiro commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@google-oss-prow

google-oss-prow Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@Philip-Carneiro: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ppadti

ppadti commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

/retest

@manaswinidas

manaswinidas commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This needs to wait for the other PR to go in and we should remove any tautological/repetitive tests

@Philip-Carneiro
add cypress coverage for manage columns behaviour in hardware conf table
87d5068 
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@Philip-Carneiro
add fix requested
a707759 
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@Philip-Carneiro
test moved to mod_arch_library
1738487 
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@Philip-Carneiro Philip-Carneiro force-pushed the test/manage-columns-cypress-coverage branch from f7fb7d1 to 1738487 Compare June 11, 2026 13:31
@Philip-Carneiro

Philip-Carneiro commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

This needs to wait for the other PR to go in and we should remove any tautological/repetitive tests

The other PR has been merged and this branch has been rebased on top of it.

Regarding tautological/repetitive tests — I did a thorough comparison between the Cypress tests in this PR and the unit tests from the mod-arch PR. They operate at different levels of the testing pyramid and cover different scopes:

  • Cypress tests (this PR): Test the integrated behavior in the Model Catalog contex, sticky columns exclusion, latency filter interaction with column visibility, and end-to-end modal workflows on the Hardware Configuration table.
  • Unit tests (mod-arch PR): Test the generic ManageColumnsModal component and useManageColumns hook in isolation, toggle callbacks, cancel behavior, search filtering, localStorage persistence, restore defaults.

The only partial overlap is the "modal opens with controls" smoke test, which exists in both — but the Cypress version navigates through the real application while the unit test renders the component with mocked props. No tests were found to be duplicated or redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chambridge chambridge Awaiting requested review from chambridge

@fege fege Awaiting requested review from fege

@manaswinidas manaswinidas Awaiting requested review from manaswinidas

Assignees

@manaswinidas manaswinidas

Labels

Area/UI size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Philip-Carneiro @manaswinidas @ppadti